tests: Allow to run polars without extra deps#3256
Merged
Conversation
FBruzzesi
commented
Oct 30, 2025
| run: pytest tests --runslow --constructors=pandas[pyarrow],pyarrow | ||
| - name: install-polars | ||
| run: | | ||
| uv pip uninstall pandas pyarrow --system |
Member
Author
There was a problem hiding this comment.
Notice that numpy will still remain installed, but the changes allow to run polars even without numpy
Member
There was a problem hiding this comment.
out of interest, why not uninstall numpy then?
Member
Author
There was a problem hiding this comment.
I should have expanded more on this.
Some polars functionalities require numpy to be installed. It comes down to either:
- uninstall numpy and do not test them
- keep numpy and test them
In both cases it's no longer dependent on pandas and pyarrow installation, which was the initial goal.
What's your take on this?
Member
There was a problem hiding this comment.
this is probably fine, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below