fix: with_row_index was returning incorrect results when used with order_by for pandas, pyarrow, and polars#3292
Merged
MarcoGorelli merged 16 commits intonarwhals-dev:mainfrom Nov 10, 2025
Conversation
…`order_by` for pandas, pyarrow, and polars
dangotbanned
reviewed
Nov 7, 2025
dangotbanned
added
fix
polars
Simplifies the signature, and we know the version can't vary for `pyarrow`
dangotbanned
reviewed
Nov 8, 2025
FBruzzesi
changed the title
order_by for pandas, pyarrow, and polarswith_row_index was returning incorrect results when used with order_by for pandas, pyarrow, and polars
Member
Author
|
shipping then, thanks for your help and review! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3289
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below