feat(expr-ir): Add date_range, support {date,int}_range(eager=...)#3294
Merged
dangotbanned merged 11 commits intooh-nodesfrom Nov 8, 2025
Merged
feat(expr-ir): Add date_range, support {date,int}_range(eager=...)#3294dangotbanned merged 11 commits intooh-nodesfrom
date_range, support {date,int}_range(eager=...)#3294dangotbanned merged 11 commits intooh-nodesfrom
Conversation
Mostly just re-purposing `int_range` *so far*, as mentioned in (#2895 (comment)) Need to think about `Interval` some more
May need tweaking pending (#2895 (comment))
Barely started covering this one
`timedelta` supports `{"d","w"}`, but not `{"mo","q","y"}`
Started working on this, but doesn't reduce the amount of code yet
lil less noisy
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
ExprIR #2572nw.int_rangefor eager backends #2895Description
date_rangewas spun out from (#2895 (comment)).Currently supporting day/week intervals only. Month/quarter/year would need dedicated support from the backend.
eager=...is adapted from #2895.The main improvement here is in the typing: