fix: pandas-like & dask join's with null values in keys#3318
Merged
Conversation
FBruzzesi
added
fix
high priority
FBruzzesi
commented
Nov 20, 2025
Member
|
thanks! will try to review next week |
MarcoGorelli
approved these changes
Nov 30, 2025
Member
MarcoGorelli
left a comment
MarcoGorelli
left a comment
There was a problem hiding this comment.
Nice one, thanks @FBruzzesi !
One of the most annoying "pandas vs the rest" differneces i've come across so far, thanks for fixing it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
joindiscrepancies when null values are in the joining keys #3307Checklist
If you have comments or can explain your changes, please do so below
Send help for better formatting the tests 😂