Skip to content

feat(expr-ir): Impl DataFrame.unique#3364

Merged
dangotbanned merged 10 commits intooh-nodesfrom
expr-ir/dataframe-unique
Dec 22, 2025
Merged

feat(expr-ir): Impl DataFrame.unique#3364
dangotbanned merged 10 commits intooh-nodesfrom
expr-ir/dataframe-unique

Conversation

@dangotbanned
Copy link
Member

@dangotbanned dangotbanned commented Dec 21, 2025 •
edited
Loading

Description

This'll be the first in a series of PRs that close gaps in non-Expr features.

Will be focusing on what is defined in DslPlan, and this one is for DslPlan::Distinct.

Related issues

@dangotbanned dangotbanned mentioned this pull request Dec 21, 2025
Draft
dangotbanned
dangotbanned commented Dec 21, 2025
View reviewed changes
dangotbanned
dangotbanned commented Dec 21, 2025
View reviewed changes
dangotbanned
dangotbanned commented Dec 21, 2025
View reviewed changes
@dangotbanned dangotbanned mentioned this pull request Dec 22, 2025
Open
@dangotbanned dangotbanned added enhancement New feature or request internal labels Dec 22, 2025
dangotbanned
dangotbanned commented Dec 22, 2025
View reviewed changes
narwhals/_plan/common.py
Comment on lines +290 to +291
class todo: # pragma: no cover # noqa: N801
"""A variation of `not_implemented`, for shorter-lived placeholders."""
Copy link
Member Author

@dangotbanned dangotbanned Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still want to have this, but it doesn't make sense now that it isn't used in the PR 😅

dangotbanned
dangotbanned commented Dec 22, 2025
View reviewed changes
dangotbanned
dangotbanned commented Dec 22, 2025
View reviewed changes
dangotbanned
dangotbanned commented Dec 22, 2025
View reviewed changes
dangotbanned
dangotbanned commented Dec 22, 2025
View reviewed changes
@dangotbanned dangotbanned marked this pull request as ready for review December 22, 2025 21:54
@dangotbanned dangotbanned merged commit 158eda2 into oh-nodes Dec 22, 2025
30 of 35 checks passed
@dangotbanned dangotbanned deleted the expr-ir/dataframe-unique branch December 22, 2025 21:57
@dangotbanned dangotbanned mentioned this pull request Dec 22, 2025
Merged
dangotbanned added a commit that referenced this pull request Dec 30, 2025
@dangotbanned
fix(expr-ir): Reject Selectors that do more than select
0f3f89c 
Fixes #3364 (comment)
@dangotbanned dangotbanned mentioned this pull request Dec 30, 2025
Merged
@dangotbanned dangotbanned mentioned this pull request Jan 23, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request internal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dangotbanned