Skip to content

feat(expr-ir): Add concat#3371

Merged
dangotbanned merged 3 commits intooh-nodesfrom
expr-ir/concat
Dec 24, 2025
Merged

feat(expr-ir): Add concat#3371
dangotbanned merged 3 commits intooh-nodesfrom
expr-ir/concat

Conversation

@dangotbanned
Copy link
Member

@dangotbanned dangotbanned commented Dec 24, 2025

Description

Episode 5 is aiming for DslPlan::Union and DslPlan::HConcat.

# `DslPlan::Union`
class VConcat(MultipleInputs[Seq[LogicalPlan]]):
"""`concat(how= "vertical" | "diagonal")`."""
__slots__ = ("options",)
options: VConcatOptions
def __repr__(self) -> str:
return "UNION"

class HConcat(MultipleInputs[Seq[LogicalPlan]]):
"""`concat(how="horizontal")`."""
__slots__ = ("strict",)
strict: bool
"""Require all `inputs` to be the same height, raising an error if not, default False."""
def __repr__(self) -> str:
return "HCONCAT"


Back over here, the compliant-level was already there - just need to get the tests in place now.

Related issues

Child of #2572
Compliant-level was already there - just need to get the tests in place now
@dangotbanned dangotbanned marked this pull request as ready for review December 24, 2025 14:01
@dangotbanned dangotbanned merged commit 59b6a5f into oh-nodes Dec 24, 2025
30 of 34 checks passed
@dangotbanned dangotbanned deleted the expr-ir/concat branch December 24, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant