Merged
Conversation
Child of #2572 Compliant-level was already there - just need to get the tests in place now
dangotbanned
commented
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Episode 5 is aiming for
DslPlan::UnionandDslPlan::HConcat.narwhals/narwhals/_plan/logical_plan/plan.py
Lines 300 to 308 in 63dbc65
narwhals/narwhals/_plan/logical_plan/plan.py
Lines 311 to 319 in 63dbc65
Back over here, the compliant-level was already there - just need to get the tests in place now.
Related issues
ExprIR #2572read_{csv,parquet}#3370