feat: Add str.pad_{start,end}#3395
Conversation
FBruzzesi
left a comment
There was a problem hiding this comment.
Thanks @camriddell , just a couple of minor details to take care of
Co-authored-by: Francesco Bruzzesi <42817048+FBruzzesi@users.noreply.github.com>
Co-authored-by: Francesco Bruzzesi <42817048+FBruzzesi@users.noreply.github.com>
Co-authored-by: Francesco Bruzzesi <42817048+FBruzzesi@users.noreply.github.com>
There was a problem hiding this comment.
Looking good @camriddell!
Only suggestion from me is to try stealing some test cases from polars and see if everything is still happy
The unicode tests look funky (pola-rs/polars#12008)
Yeah, fingers crossed that these are handled somewhat consistently/supported across backends. I'll pull these tests over and see where we land! |
|
@dangotbanned those unicode tests fit into place without any poking from me :) |
dangotbanned
left a comment
There was a problem hiding this comment.
@dangotbanned those unicode tests fit into place without any poking from me :)
Happy to hear it, thanks @camriddell!
I'm jealous of how small this PR is 😉
str.pad_{start,end}

Description
Adds
str.pad_startandstr.pad_endto pad strings within a column.What type of PR is this? (check all applicable)
Related issues
Checklist