feat: Support other Expr/Series in str.contains for polars and SQL-like backends#3473
Merged
feat: Support other Expr/Series in str.contains for polars and SQL-like backends#3473
str.contains for polars and SQL-like backends#3473Conversation
FBruzzesi
commented
Feb 9, 2026
Member
MarcoGorelli
left a comment
MarcoGorelli
left a comment
There was a problem hiding this comment.
thanks @FBruzzesi !
on board with the feature, implementation-wise is it possible to follow str.replace more closely for what we do there for value (which can be an expression)?
narwhals/_sql/expr_str.py
Outdated
| if literal: | ||
| return self._function("contains", expr, self._lit(pattern)) | ||
| return self._function("regexp_matches", expr, self._lit(pattern)) | ||
| def contains(self, pattern: str | SQLExprT, *, literal: bool) -> SQLExprT: |
Member
There was a problem hiding this comment.
i'm a little skeptical of the signature here, as for str.replace we have
narwhals/narwhals/_sql/expr_str.py
Line 52 in bf502eb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For polars and SQL-like backends it's straightforward to support expressions and series in
str.contains.For pandas, pyarrow and dask a better error is not raised
What type of PR is this? (check all applicable)
Related issues
Checklist