Skip to content

feat: add when chaining#669

Closed
aivanoved wants to merge 76 commits intonarwhals-dev:mainfrom
aivanoved:add-when-chaining
Closed

feat: add when chaining#669
aivanoved wants to merge 76 commits intonarwhals-dev:mainfrom
aivanoved:add-when-chaining

Conversation

@aivanoved
Copy link
Copy Markdown
Contributor

@aivanoved aivanoved commented Jul 29, 2024 •
edited
Loading

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Address failing CI
  • Make stable
  • Documented the changes

If you have comments or can explain your changes, please do so below.

aivanoved and others added 30 commits July 17, 2024 12:38
@aivanoved
add simple when
d7446f4
@aivanoved
delete unnecessary file
6ebc78b
@aivanoved
lint with ruff
a3fdcc5
@aivanoved
use lambda expression
1ad1c94
@aivanoved
Merge branch 'main' into add-where-expression
55f394f
@aivanoved
remove deleted file
93e7121
@aivanoved
Fix errors from the migration
f3770b7
@aivanoved
Merge branch 'main' into add-where-expression
cf92f80
@aivanoved
remove unnecessary changes
a7f442a
@aivanoved
add back the change in version
7f23f05
@aivanoved
fix rename change
7cc3aad
@aivanoved
rename test file
ab85e40
@aivanoved
fix forgotten memeber change
4a8ac56
@aivanoved
make api identical
8283f24
@aivanoved
remove unnecessary diff
f1c667e
@aivanoved
add when documentation
74937ea
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
5b030d6 
for more information, see https://pre-commit.ci
@aivanoved
address mypy issues
7390e1a
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
279e3ad 
for more information, see https://pre-commit.ci
@aivanoved
address ruff type-ignore blanket issue
63048ee
@aivanoved
support Iterable[Expr] in the pandas api
e96af89
@aivanoved
move when test file to a better location
d4f0e9c
@aivanoved
make when test filename similar to other tests
99d9899
@aivanoved
add simple when
71e542d
@aivanoved
lint with ruff
8b1355a
@aivanoved
use lambda expression
eb36164
@aivanoved
Fix errors from the migration
c9b09bf
@aivanoved
remove unnecessary changes
2b1eabc
@aivanoved
remove unnecessary diff
2ef564e
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
0e4773d 
for more information, see https://pre-commit.ci
@aivanoved aivanoved marked this pull request as ready for review September 11, 2024 21:10
@aivanoved
Copy link
Copy Markdown
Contributor Author

aivanoved commented Sep 11, 2024

@FBruzzesi I am slightly confused, it seems that a lot of the ci fails don't have anything to do with the changes in this pr?
can you confirm this?

@FBruzzesi
Copy link
Copy Markdown
Member

FBruzzesi commented Sep 12, 2024

@FBruzzesi I am slightly confused, it seems that a lot of the ci fails don't have anything to do with the changes in this pr? can you confirm this?

It's definitly unrelated. Also #942 passed all the tests. Polars had a new release, that's probably worth investigating

@MarcoGorelli
Copy link
Copy Markdown
Member

MarcoGorelli commented Sep 14, 2024

yup, sorry about that - CI is green now 🥦

aivanoved
aivanoved commented Sep 16, 2024
View reviewed changes
@aivanoved
Copy link
Copy Markdown
Contributor Author

aivanoved commented Sep 16, 2024

@FBruzzesi @MarcoGorelli I think this is ready for review now

@aivanoved
Copy link
Copy Markdown
Contributor Author

aivanoved commented Oct 18, 2024

ping @MarcoGorelli @FBruzzesi

I'll resolve the merge conficts

@FBruzzesi FBruzzesi mentioned this pull request Mar 5, 2025
Closed
@dangotbanned dangotbanned mentioned this pull request Mar 21, 2025
Merged
20 tasks
@aivanoved
Copy link
Copy Markdown
Contributor Author

aivanoved commented Mar 27, 2025

With the merging of #2261 should we close this one @MarcoGorelli

@MarcoGorelli
Copy link
Copy Markdown
Member

MarcoGorelli commented Mar 27, 2025

yeah maybe, sorry to close this - thanks for your PR, appreciate you having got the ball rolling on this one! 🙏

@aivanoved
Copy link
Copy Markdown
Contributor Author

aivanoved commented Mar 27, 2025 •
edited
Loading

No worries, unfortunately I haven't had the time to continue contributing so is good this has been resolved. Thank you @MarcoGorelli and team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add when-then-otherwise

3 participants

@aivanoved @FBruzzesi @MarcoGorelli