Skip to content

feat: Add join_asof support for pandas and dask#911

Merged
MarcoGorelli merged 10 commits intonarwhals-dev:mainfrom
raisadz:add-joinasof
Sep 6, 2024
Merged

feat: Add join_asof support for pandas and dask#911
MarcoGorelli merged 10 commits intonarwhals-dev:mainfrom
raisadz:add-joinasof

Conversation

@raisadz
Copy link
Contributor

@raisadz raisadz commented Sep 5, 2024

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

@MarcoGorelli MarcoGorelli changed the title Add join_asof support for pandas and dask feat: Add join_asof support for pandas and dask Sep 5, 2024
@github-actions github-actions bot added the enhancement New feature or request label Sep 5, 2024
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is amazing, thanks @raisadz !

@MarcoGorelli MarcoGorelli merged commit 029f590 into narwhals-dev:main Sep 6, 2024
@MarcoGorelli MarcoGorelli mentioned this pull request Sep 7, 2024
@raisadz raisadz deleted the add-joinasof branch November 7, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants