Fix non-default feature build: Feature gate unpack_ffmpeg with download_ffmpeg#56
Merged
nathanbabcock merged 2 commits intoNov 4, 2024
Conversation
unpack_ffmpeg with download_ffmpegunpack_ffmpeg with download_ffmpeg
Contributor
Author
|
Don't know where else to write that: Awesome project! So much nicer than interfacing with the ffmpeg libraries directly Using it in the |
nathanbabcock
approved these changes
Nov 4, 2024
Owner
nathanbabcock
left a comment
There was a problem hiding this comment.
Great catch, thank you for fixing this.
I'm going to merge this and then create a small follow-up to also add the cargo check step for Mac M1, and perhaps also share some of those common steps across jobs.
Thank you for the kind words, and I'm excited to check out Rerun more deeply. If you run across any pain points or ideas for improvements in the future I would love to hear them!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently compilation fails when building for non-linux without the
download_ffmpegfeature.This happens because the
ziplibrary is (correctly) feature gated todownload_ffmpeg. This in turn is used byunpack_ffmpegwhich wasn't behind the feature flag!