Log config warnings in the logs, not on stderr#7621
Open
alexbozhenko wants to merge 1 commit intomainfrom
Open
Log config warnings in the logs, not on stderr#7621alexbozhenko wants to merge 1 commit intomainfrom
alexbozhenko wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: Alex Bozhenko <alexbozhenko@gmail.com>
Member
neilalexander
left a comment
There was a problem hiding this comment.
My understanding is that we always write these configuration errors directly to stderr as we don't know at that point whether we have successfully parsed any other log-related options that could redirect them elsewhere or obscure them from view.
Do you have any thoughts @derekcollison?
(To my knowledge Kubernetes and systemd both capture stdout+stderr by default, can't speak for Nix though.)
Member
|
IIRC we do stderr for errors and warnings and stdout for INFO. But I would need to look, that was done over a decade ago. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, config parsing warnings are printed on stderr.
Depending on how the server is deployed(systemd, k8s, nix, etc...) and how the logs are aggregated, this stderr may be lost and will not show up where all the other nats servers logs are.
Test plan:
This will make print the config parsing warnings using whatever logging we configured, not on stderr, where it can be never noticed.
Signed-off-by: Alex Bozhenko alexbozhenko@gmail.com