[FIXED] JetStream leaks subs with overlapping stream import#7720
Merged
neilalexander merged 1 commit intomainfrom Jan 13, 2026
Merged
[FIXED] JetStream leaks subs with overlapping stream import#7720neilalexander merged 1 commit intomainfrom
neilalexander merged 1 commit intomainfrom
Conversation
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
This was referenced Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given a clustered setup where two accounts use stream imports/exports which overlap the
$JS.>subject hierarchy, any servers that didn't host the stream/consumer asset would be made aware of this through 'shadow subs' due to the stream import. However, these weren't cleaned up during unsubscribing if the stream/consumer was deleted, leading to essentially leaking these subscriptions.We'll now also update the routes if we had 'shadow subs' for the internal JetStream client.
Resolves #7718
Signed-off-by: Maurice van Veen github@mauricevanveen.com