Cherry-picks for v2.12.4-RC.3#7742
Merged
neilalexander merged 8 commits intorelease/v2.12.4from Jan 20, 2026
Merged
Conversation
…null" in the `sources` array. Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
The config parser allows for environment variables to reference
other environment variables. However, self references or cycles
would cause the parser to enter an infinite recursion.
This commit introduces cycle detection in the environment
variable lookup process, so that the parser handles cycles
and self-references gracefully.
A set of tests check that the current behavior of the parser
did not change:
- variables can reference other variables, as well
as environment variables
- environment variables can reference other
evironment variables, but not local variables
Fixes #7730
Signed-off-by: Daniele Sciascia <daniele@nats.io>
Signed-off-by: Waldemar Quevedo <wally@nats.io>
|
@neilalexander will this produce an image that I'd be able to verify with, seeing as our last tests were based on a different approach? |
Member
Author
|
@webstradev Yep, it's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes the following:
Signed-off-by: Neil Twigg neil@nats.io