Skip to content

Cherry-picks for v2.11.12-RC.4#7743

Merged
neilalexander merged 8 commits intorelease/v2.11.12from
backports/v2.11.12-RC.4
Jan 20, 2026
Merged

Cherry-picks for v2.11.12-RC.4#7743
neilalexander merged 8 commits intorelease/v2.11.12from
backports/v2.11.12-RC.4

Conversation

@neilalexander
Copy link
Member

@neilalexander neilalexander commented Jan 20, 2026

jnmoyne and others added 6 commits January 20, 2026 10:40
…null" in the `sources` array.

Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander neilalexander requested a review from a team as a code owner January 20, 2026 10:43
The config parser allows for environment variables to reference
other environment variables. However, self references or cycles
would cause the parser to enter an infinite recursion.

This commit introduces cycle detection in the environment
variable lookup process, so that the parser handles cycles
and self-references gracefully.
A set of tests check that the current behavior of the parser
did not change:

    - variables can reference other variables, as well
      as environment variables
    - environment variables can reference other
      evironment variables, but not local variables

Fixes #7730

Signed-off-by: Daniele Sciascia <daniele@nats.io>
Copy link
Member

@MauriceVanVeen MauriceVanVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Waldemar Quevedo <wally@nats.io>
@neilalexander neilalexander merged commit 7eee2a9 into release/v2.11.12 Jan 20, 2026
48 checks passed
@neilalexander neilalexander deleted the backports/v2.11.12-RC.4 branch January 20, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants