Skip to content

Comments

Fix subject intersection bug due to early return#7745

Merged
neilalexander merged 1 commit intomainfrom
neil/subjectintersectionfix
Jan 20, 2026
Merged

Fix subject intersection bug due to early return#7745
neilalexander merged 1 commit intomainfrom
neil/subjectintersectionfix

Conversation

@neilalexander
Copy link
Member

An early return here meant that a wildcard with differing following literal tokens would mask another literal at the same level as the partial wildcard.

Signed-off-by: Neil Twigg neil@nats.io

Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander neilalexander requested a review from a team as a code owner January 20, 2026 13:54
Copy link
Member

@MauriceVanVeen MauriceVanVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 74c1231 into main Jan 20, 2026
48 checks passed
@neilalexander neilalexander deleted the neil/subjectintersectionfix branch January 20, 2026 14:08
neilalexander added a commit that referenced this pull request Jan 20, 2026
Includes the following:

- #7745

Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander added a commit that referenced this pull request Jan 20, 2026
Includes the following:

- #7745

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants