Skip to content

Comments

[IMPROVED] Only recalculate pending with updated filter subject(s)#7753

Merged
neilalexander merged 1 commit intomainfrom
maurice/recalc-pending
Jan 22, 2026
Merged

[IMPROVED] Only recalculate pending with updated filter subject(s)#7753
neilalexander merged 1 commit intomainfrom
maurice/recalc-pending

Conversation

@MauriceVanVeen
Copy link
Member

Pending would be recalculated for every consumer update, which could be expensive (and redundant) if the filter subjects weren't updated. Additionally, cleaning up messages that lost interest could be expensive if the filters didn't change.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner January 22, 2026 11:55
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 615cffe into main Jan 22, 2026
48 checks passed
@neilalexander neilalexander deleted the maurice/recalc-pending branch January 22, 2026 12:06
neilalexander added a commit that referenced this pull request Jan 26, 2026
Includes the following:

- #7750
- #7752
- #7751
- #7753
- #7758
- #7759
- #7763

Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander added a commit that referenced this pull request Jan 26, 2026
Includes the following:

- #7750
- #7752
- #7751
- #7753
- #7759
- #7763

Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander added a commit that referenced this pull request Jan 27, 2026
#7772)

Follow-up of #7753. We can
simplify since we already captured whether the filters changed above
this.

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants