-
Notifications
You must be signed in to change notification settings - Fork 157
[ADDED] ObjectStore support #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #902 +/- ##
==========================================
+ Coverage 70.14% 70.22% +0.08%
==========================================
Files 47 48 +1
Lines 15593 17259 +1666
Branches 3212 3540 +328
==========================================
+ Hits 10937 12120 +1183
- Misses 1568 1736 +168
- Partials 3088 3403 +315 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Objects: - natsHeader - objStoreConfig - objStore - objStoreMeta - objStoreMetaOptions - objStoreInfo - objStoreLink - objStoreOptions - objStorePut - objStoreGet - objStoreInfoList - objStoreNamesList - objStoreStatus - objStoreStatusList - objStoreWatcher - objStoreWatchOptions Global Management APIs: - objStoreConfig_Init - js_CreateObjectStore - js_UpdateObjectStore - js_ObjectStore - js_ObjectStoreNames - objStoreNamesList_Destroy - js_ObjectStoreStatuses - objStoreStatusesList_Destroy - js_DeleteObjectStore Per-store Management APIs: - objStoreOptions_Init - objStore_GetInfo - objStoreMeta_Init - natsHeader_New - natsHeader_Set - natsHeader_Add - natsHeader_Get - natsHeader_Keys - natsHeader_KeysCount - natsHeader_Values - natsHeader_Delete - natsHeader_Destroy - objStore_Put - objStorePut_Add - objStorePut_Complete - objStorePut_Destroy - objStore_PutString - objStore_PutBytes - objStore_PutFile - objStoreInfo_Destroy - objStore_Get - objStoreGet_Info - objStoreGet_Read - objStoreGet_ReadAll - objStoreGet_Destroy - objStore_GetString - objStore_GetBytes - objStore_GetFile - objStore_UpdateMeta - objStore_Delete - objStore_Seal - objStore_Status - objStoreStatus_Destroy - objStore_AddLink - objStore_AddBucketLink - objStoreWatchOptions_Init - objStore_Watch - objStoreWatcher_Next - objStoreWatcher_Stop - objStoreWatcher_Destroy - objStore_List - objStoreList_Destroy - objStore_Destroy Resolves #876 Signed-off-by: Ivan Kozlovic <[email protected]>
aricart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - wow!
|
I checked and the encoding of the base64 is correct, was surprised by all the header implementation. |
Release notes will be: This release contains some breaking changes. See the "Changed" section below. * Build * Disable NATS Streaming by default by @mtmk in #770 * TLS * Require OpenSSL 1.1.1+ to compile. Removed the `NATS_BUILD_TLS_USE_OPENSSL_1_1_API` CMake variable by @kozlovic in #905 * The option `natsOptions_SetSSLVerificationCallback` signature was changed to replace the use of `SSL_verify_cb` (which required OpenSSL dependency in the `nats.h` file), to the new callback `natsSSLVerifyCb`. See documentation of `natsSSLVerifyCb` to see the cast needed to compile with this new header file by @kozlovic in #908 * Modification of a `natsOptions` object if it has TLS/SSL configuration and is actively used by connections will now return a `NATS_ILLEGAL_STATE` by @kozlovic in #912 * Options * Ability to load the trusted CA certificates from a directory using the new option `natsOptions_LoadCATrustedCertificatesPath` by @kerbert101 in #862 * Ability to connect via HTTP proxy for instance by adding a proxy connection handler using the new option `natsOptions_SetProxyConnHandler` by @wolfkor in #871 and @kozlovic in #897 * Ability to load the certificate chain and key from a file on every connection attempt using the new option `natsOptions_LoadCertificatesChainDynamic` by @Matus-p in #901 * Ability to perform concurrent TLS handshakes that may improve time it takes for concurrent connections to be established using the new option `natsOptions_AllowConcurrentTLSHandshakes ` by @kozlovic in #914. Issue was reported by @yanyongcheng in #899 * JetStream * Per-message TTL support (a NATS Server v2.11 feature) by @levb in #863 * Pull consumer priority groups (a NATS Server v2.11 feature) by @levb in #869 * ObjectStore support by @kozlovic in #902. Thanks to @jfflynn41 and @alex1891 for the feedback in #876 * JetStream * Handling of publish asynchronous timeouts by @kozlovic in #886. Issue reported by @yanyongcheng in #880 * Timer insertion by @kozlovic in #883. Issue reported by @yanyongcheng in #881 * EventLoop: * Handling of possible failure on initial attach by @kozlovic in #918 * LibEvent: `natsConnection_Close()` not closing the TCP connection by @kozlovic in #882. Issue was reported by @yanyongcheng in #879 * Libuv: Possible crash if connection is destroyed while receiving data by @kozlovic in #889. Issue was reported by @yanyongcheng in #888 * KeyValue * Keys, History or watcher's next may incorrectly return `NATS_TIMEOUT` by @kozlovic in #917/ Issue was reported by @ArashPartow in #916 * MicroServices: * Wrong marshaling of `average_processing_time` by @kozlovic in #892. Issue was reported by @Archie3d in #890 * Statistics error was always incremented by @kozlovic in #894. Issue was reported by @Archie3d in #893 * TLS * Unknown type name `SSL_verify_cb` by @kozlovic in #878. Issue was reported by @philipfoulkes in #877 * Initialization and cleanup code related to OpenSSL was removed since it was deprecated for versions post OpenSSL 1.1. A cleanup function pertinent to 1.1+ code was possibly causing a problem. By @kozlovic in #905. Issue was reported by @vdeters in #904 * Possible hang during handshake by @kozlovic in #907. Issue was reported by @etrochim in #906 * Protect calls to `SSL_read` and `SSL_write` with a mutex. Since the same `SSL` object is shared between different threads, the OpenSSL library requires a mutex to be used by @kozlovic in #913 * Memory allocation check by @wooffie in #868 * Add missing status text string by @oldnick85 in #872 and @kozlovic in #874 (the issue was not present in any published release and was introduced in #869) * Parsing of message headers with `NULL` or all-whitespace values by @habbbe in #873 * Removed some unused code related to handling of responses and added custom inbox with very long prefix test by @kozlovic in #885. Issue was reported by @yanyongcheng in #884 * Connection drain could cause missed reply and/or a 100ms delay by @kozlovic in #915. Issue was reported by @T-Maxxx in #911 * Build * Deprecated Ubuntu 20.04 in GitHub actions by @levb in #864 * Removed the older compiler jobs by @levb in #865 * Fixed Windows build to use the NATS Server main branch by @levb in #866 * @kerbert101 made their first contribution in #862 * @habbbe made their first contribution in #873 * @wolfkor made their first contribution in #871 * @Matus-p made their first contribution in #901 Signed-off-by: Ivan Kozlovic <[email protected]>
Objects:
Global Management APIs:
Per-store Management APIs:
Resolves #876