[CHANGED] const correctness for kvStore_Watch, kvStore_WatchMulti and kvStore_WatchAll options #930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… kvStore_WatchAll options
kozlovic
approved these changes
Nov 11, 2025
Member
kozlovic
left a comment
kozlovic
left a comment
There was a problem hiding this comment.
LGTM. I will review the other kv operations that accept options, and assuming that the APIs can't change them, will change to const to be complete.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 11, 2025
…om/const-watch-options
kozlovic
added a commit
that referenced
this pull request
Nov 12, 2025
Follow up on PRs #929 and #930 Signed-off-by: Ivan Kozlovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems reasonable that the options are read-only (const) parameters here.
Is that true more broadly? I wonder.