Split dev dependencies into separate modules#1788
Conversation
d00aaba to
3428b6e
Compare
go.mod
Outdated
| github.com/nats-io/nkeys v0.4.9 | ||
| github.com/nats-io/nuid v1.0.1 | ||
| golang.org/x/text v0.21.0 | ||
| google.golang.org/protobuf v1.36.2 |
There was a problem hiding this comment.
would this one be needed if we put a go.mod under encoders?
There was a problem hiding this comment.
Not really under encoders - enc.go imports encoders/builtin, so even if we put it in a separate module, it would have to be added to root go.mod (with protobuf as an indirect dependency), so does not make sense.
We could in theory make encoders/protobuf a separate module but then we'd have to release and version it separately, not sure it's a good solution.
|
Why is this a good idea? Who else does it this way? |
|
I guess that's because we do not want circular dependency between server and nats.go. |
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
3428b6e to
2e756a7
Compare
Signed-off-by: Piotr Piotrowski piotr@synadia.com