Skip to content

add http port exposure and ingress addition#15

Merged
maxwellgagnon merged 4 commits intomainfrom
eywalker/plt-70-add-http-port-exposure-and-ingress-addition
Oct 3, 2025
Merged

add http port exposure and ingress addition#15
maxwellgagnon merged 4 commits intomainfrom
eywalker/plt-70-add-http-port-exposure-and-ingress-addition

Conversation

@eywalker
Copy link
Copy Markdown
Contributor

@eywalker eywalker commented Oct 3, 2025

  • add support for ingress and port exposure, along with basic authentication setup via OAuth2 server
  • refine and reorganize statefulset template

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds HTTP port exposure and ingress capabilities to the devenv-engine, enabling external HTTP access to development environments with optional OAuth2 authentication.

Key changes:

  • Added ingress template with SSL termination and optional OAuth2 authentication
  • Refactored statefulset template to improve container configuration and remove SSH key mounting
  • Extended configuration to support hostname and authentication settings

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
internal/templates/renderer.go Added "ingress" to the list of templates to render
internal/templates/files/statefulset.tmpl Reorganized container configuration, removed SSH keys, updated security context
internal/templates/files/ingress.tmpl New template for HTTP ingress with SSL and OAuth2 support
internal/templates/files/env-vars.tmpl Added IS_ADMIN environment variable
internal/config/types.go Added configuration fields for hostname and authentication

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@maxwellgagnon maxwellgagnon merged commit 5896430 into main Oct 3, 2025
2 checks passed
@eywalker eywalker deleted the eywalker/plt-70-add-http-port-exposure-and-ingress-addition branch October 7, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants