Skip to content

Pipeline Runner Implementation#111

Merged
eywalker merged 48 commits intonauticalab:devfrom
Synicix:runner
Oct 20, 2025
Merged

Pipeline Runner Implementation#111
eywalker merged 48 commits intonauticalab:devfrom
Synicix:runner

Conversation

@Synicix
Copy link
Copy Markdown
Contributor

@Synicix Synicix commented Aug 13, 2025

Summary of changes from top to bottom in files changed:

  • Update test.yaml tool change to latest rust version 1.87 -> 1.89
  • Remove stale setting that is no longer available in VS code.
  • Added back functions to pipeline.rs. that are required by pipeline runner (move core/pipeline.rs to model/pipeline.rs
  • Added pipeline_runner with new integration with agent + design change from last week due to communication change + operator
  • Added function to_path_buf to PathSet since it is a common conversion people will use
  • Rename PipelineNode to Node URI
  • Added Pipeline result
  • Added sentence building test case for pipeline

Solve #103

Resolves PIPE-113
Resolves PIPE-116

@Synicix Synicix marked this pull request as ready for review August 15, 2025 11:00
@Synicix Synicix requested review from Copilot and eywalker August 15, 2025 11:00

This comment was marked as outdated.

@Synicix Synicix changed the title Runner Pipeline Runner Implementation Aug 28, 2025
@Synicix Synicix requested a review from Copilot August 29, 2025 05:37
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a comprehensive pipeline runner system with significant architectural changes and updates to core components.

  • Adds a new DockerPipelineRunner that orchestrates pipeline execution using Zenoh communication
  • Restructures pipeline models by moving PipelineNode from core/pipeline.rs to model/pipeline.rs
  • Introduces pipeline result tracking with status management and failure logging
  • Updates API naming conventions across the codebase (e.g., nextprocess_packet, SpecURINodeURI)

Reviewed Changes

Copilot reviewed 36 out of 37 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tests/pipeline_runner.rs New integration test for pipeline execution workflow
tests/fixture/mod.rs Added pipeline test fixtures and data structures
src/core/pipeline_runner.rs New pipeline runner implementation with async task management
src/uniffi/model/pipeline.rs Enhanced pipeline models with new status types and result structures
src/core/model/pipeline.rs Moved and expanded pipeline node definitions
src/core/operator.rs Updated operator trait method names and added serialization
tests/extra/data/input_txt/* Test data files for pipeline integration tests
.github/workflows/tests.yaml Updated Rust toolchain version
Comments suppressed due to low confidence (1)

tests/fixture/mod.rs:1

  • Malformed text with broken backticks and typos. Should be 'based on the pipeline_job and pipeline_spec'
#![expect(

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

)]))?;
let namespace_lookup = test_dirs.namespace_lookup();

// Create and agent and start it (temporary for now, will be merge later)
Copy link

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatical error: 'and' should be 'an' - 'Create an agent and start it'

Suggested change
// Create and agent and start it (temporary for now, will be merge later)
// Create an agent and start it (temporary for now, will be merge later)

Copilot uses AI. Check for mistakes.
error: String,
}

/// Internal representation of a pipeline run, this should not be made public due to the fact that it contains
Copy link

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing comma after 'run' - should be 'Internal representation of a pipeline run, which should not be made public due to the fact that it contains'

Suggested change
/// Internal representation of a pipeline run, this should not be made public due to the fact that it contains
/// Internal representation of a pipeline run, which should not be made public due to the fact that it contains

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it'd make sense for us to be sharing vscode settings in the repo? Let's be sure to remove this in a future PR.

@eywalker eywalker merged commit 8180f3d into nauticalab:dev Oct 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unified Zenoh-io key expression communication layout and support multi-tier user group labels Create a separate Enum for pod_result status

3 participants