Generics and annotation improvements, Part 2

[guzman-raphael]

Following the merge of #34 , this PR applies the ideas in my review.

Below is a summary of all the features that were accomplished across both PRs.

Features

• Use generic methods
• Make deletes explicit (delete_annotation, delete_pod), remove checks in delete_pod since deletes are explicit, and prevent deletion of the last annotation in delete_annotation
• Change annotation save path (annotation subdirectory in model directory)
• Make annotation optional for load_pod and delete_pod but required for save_pod
• Support loading or deleting pod from a hash or name/version (via ModelID)
• Make Result pub
• Expose LocalFileStore.directory only via getter
• Use impl AsRef<Path> as opposed to impl Into<PathBuf>
• Apply map to format desired in list_model. Currently, just passing through Vec<ModelInfo>.

Minor Improvements

• Make path builder more general
• Use a Vec<ModelInfo> internally when parsing annotation path
• Compile regex once instead of in each iteration (moved out of map via move)
• Parse class in regex
• Make save_file more flexible
• Use YAML content as opposed to files in from_yaml
• Add lookup_hash based on name/version
• Remove get_version_map since unneeded with explicit deletes
• Remove FileHasNoParent error
• Rename parse_annotation_path(path) -> find_annotation(glob_pattern) to improve readability.
• Add snake_case utility
• Simplify util methods
• Simplify to_yaml usage
• Update docs

Tests

• Removed tests introduced in Add genrics store function, modify parse annotation path to search an… #34 so they are addressed separately Tests have been reworked to align with the original fixture design. Includes tests from Add genrics store function, modify parse annotation path to search an… #34. Improves code coverage from ~70% -> ~72%.
• Allow expect usage in tests to simplify
• Add pod_load test
• Add equality support in Pod
• Add test for list_pod when none exist yet
• Create store dir in fixture when initializing so drop doesn't panic
• Make empty dir check in tests take an arg for # of levels up
• Pull out implementations from fixture functions

Dev Improvements

• Make spec/annotation paths and filenames easier to change in the future
• Add spell checker w/ a word ignore list
• Fix typos

[Synicix]

So there is a couple of discussion points we should probably go over next time we meet:

• How to deal with annotationless models. Seems that we have different apporches on how to handle that
• Test changes should adopt new design for generics?
• What should list_model return