Refactoring and cleanup #14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant refactoring and improvements to the logging and configuration handling in the
outboundplugin, as well as updates to the testing framework. The most important changes include extracting the Go version fromgo.mod, restructuring the logging setup, and enhancing the configuration parsing logic.Configuration and Build Improvements:
Makefile: Extracted the Go version directly fromgo.modand passed it as a build argument to the Docker build process. Introduced targets for testing and cleaning Docker images.Logging Enhancements:
outbound.go: Refactored the logging setup by renamingsetupLoggingtosetupPluginLoggingand updating the logging configuration process. Added new structured logging instances and metadata handling. [1] [2] [3]Configuration Parsing Refactor:
outbound.go: Split theparseConfigfunction into smaller, more manageable functions (readJSONConfig,setupPluginLogging,parsePrevResult,applyAdditionalRules). This improves readability and maintainability. [1] [2]Testing Updates:
outbound_test.go: Updated tests to reflect the refactored logging and configuration parsing functions. Added new tests to handle scenarios where parsing previous results or finding IPv4 addresses fails. [1] [2]IPTables Management:
pkg/iptables/iptables_manager.go: Added a new methodRemoveJumpRuleByTargetChainto theManagerinterface and updated theIPTablesManagerimplementation. [1] [2]