Skip to content

fix(web): prevent Safari IME composition Enter from sending message #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilblackdragon merged 2 commits into from
Mar 15, 2026
Merged

fix(web): prevent Safari IME composition Enter from sending message #1140

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25dfc5d
fix(web): handle Safari IME composition Enter key
micsama Mar 13, 2026
85c9001
fix(web): improve Safari IME comment with WebKit bug reference
micsama Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/channels/web/static/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1688,7 +1688,10 @@ chatInput.addEventListener('keydown', (e) => {
}
}

if (e.key === 'Enter' && !e.shiftKey && !e.isComposing) {
// Safari fires compositionend before keydown, so e.isComposing is already false
// when Enter confirms IME input. keyCode 229 (VK_PROCESS) catches this case.
// See https://bugs.webkit.org/show_bug.cgi?id=165004
if (e.key === 'Enter' && !e.shiftKey && !e.isComposing && e.keyCode !== 229) {
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve readability and maintainability, consider extracting the magic number 229 into a named constant like const VK_PROCESS = 229;. This could be defined at a suitable scope (e.g., at the top of the file). The comment already helpfully mentions VK_PROCESS, and using a constant would make the code even clearer.

e.preventDefault();
hideSlashAutocomplete();
sendMessage();
Expand Down
Loading