Skip to content

Docker: only tag :latest on release, allow :staging via dispatch#1925

Merged
Evrard-Nil merged 1 commit intostagingfrom
feat/docker-staging-tag
Apr 2, 2026
Merged

Docker: only tag :latest on release, allow :staging via dispatch#1925
Evrard-Nil merged 1 commit intostagingfrom
feat/docker-staging-tag

Conversation

@Evrard-Nil
Copy link
Copy Markdown
Contributor

Summary

  • Only push :latest tag when triggered by release (workflow_call)
  • Manual workflow_dispatch pushes :{version} + :sha-{commit} only
  • Pass tag: staging in manual dispatch to also push :staging

Test plan

  • Manual dispatch without tag → pushes :{version} + :sha-xxx only
  • Manual dispatch with tag: staging → pushes :{version} + :sha-xxx + :staging
  • Release via tag push → pushes :{version} + :latest + :sha-xxx

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings April 2, 2026 18:03
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@github-actions github-actions bot added scope: ci CI/CD workflows size: S 10-49 changed lines risk: medium Business logic, config, or moderate-risk modules contributor: regular 2-5 merged PRs labels Apr 2, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Docker publish workflow to avoid tagging :latest for manually-triggered builds while still producing immutable version/SHA tags, aligning image tagging with release semantics.

Changes:

  • Tag :latest only when the workflow runs via workflow_call (intended for release runs).
  • For workflow_dispatch, publish only :{version} and :sha-{commit} by default.
  • Continue supporting an optional extra tag via inputs.tag (e.g., staging).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/docker.yml
Comment thread .github/workflows/docker.yml
@Evrard-Nil Evrard-Nil force-pushed the feat/docker-staging-tag branch from 4be3f80 to b035063 Compare April 2, 2026 18:58
@Evrard-Nil Evrard-Nil requested a review from serrrfirat April 2, 2026 19:14
@Evrard-Nil Evrard-Nil merged commit a3cf7b4 into staging Apr 2, 2026
14 checks passed
@Evrard-Nil Evrard-Nil deleted the feat/docker-staging-tag branch April 2, 2026 19:43
serrrfirat pushed a commit that referenced this pull request Apr 5, 2026
This was referenced Apr 5, 2026
drchirag1991 pushed a commit to drchirag1991/ironclaw that referenced this pull request Apr 8, 2026
@ironclaw-ci ironclaw-ci bot mentioned this pull request Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor: regular 2-5 merged PRs risk: medium Business logic, config, or moderate-risk modules scope: ci CI/CD workflows size: S 10-49 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants