fix(ci): target wasm32-wasip2 in WASM build script#2175
Merged
serrrfirat merged 2 commits intostagingfrom Apr 9, 2026
Merged
Conversation
cargo-component defaults to wasm32-wasip1 in CI, placing the binary at the wrong path. All slack_auth_integration tests panic because they look for the module at the wasm32-wasip2 target directory. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
size: XS
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes CI WASM build output placement by explicitly targeting wasm32-wasip2 when building channel/tool components, aligning produced artifacts with what integration tests expect.
Changes:
- Add
--target wasm32-wasip2tocargo component buildin the WASM extensions build script.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the scripts/build-wasm-extensions.sh script to specify the wasm32-wasip2 target during the WASM extension build process. A review comment suggests adding the --locked flag to the cargo component build command to ensure reproducible builds by enforcing the use of the Cargo.lock file.
github-actions
Bot
added
size: S
nickpismenkov
approved these changes
Apr 9, 2026
This was referenced Apr 9, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo-componentdefaults towasm32-wasip1, placing WASM binaries at the wrong target pathslack_auth_integrationtests panic because they look for the module atwasm32-wasip2--target wasm32-wasip2tocargo component buildin the build scriptRoot cause
The
Creating componentstep in CI outputs tochannels-src/slack/target/wasm32-wasip1/release/slack_channel.wasm, but the test macrorequire_slack_wasm!()checkswasm32-wasip2. The binary was built successfully — just at the wrong path.CI run: https://github.com/nearai/ironclaw/actions/runs/24160181770/job/70509336674
Test plan
./scripts/build-wasm-extensions.sh --channels— confirms binary atwasm32-wasip2pathcargo test --test slack_auth_integration— all 5 tests pass locally🤖 Generated with Claude Code