test(e2e): add Playwright persistence happy-path test#2475
Merged
henrypark133 merged 2 commits intostagingfrom Apr 14, 2026
Merged
test(e2e): add Playwright persistence happy-path test#2475henrypark133 merged 2 commits intostagingfrom
henrypark133 merged 2 commits intostagingfrom
Conversation
Add `test_message_persists_across_page_reload` which validates the full persistence round-trip: send a message via the chat UI, reload the page (clearing all client-side state), switch back to the thread, and verify both user message and assistant response are restored from the database. Cross-checks via the history API that exactly one user turn exists with a completed response. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
bot
added
size: XS
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new end-to-end test to ensure that chat messages and assistant responses are correctly persisted and retrieved from the database after a page reload. The review feedback suggests improving test reliability by replacing a hardcoded sleep with a conditional wait and adhering to project conventions by using the centralized selector dictionary for the authentication screen.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an end-to-end regression test to ensure chat messages persist across a full browser reload, validating both UI rehydration and server-side history persistence for a single completed turn.
Changes:
- Add
test_message_persists_across_page_reloadPlaywright E2E test covering send → persist → reload → re-render. - Validate persistence via both DOM assertions (user + assistant messages visible) and
/api/chat/historycross-check (single completed user turn).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Replace fixed `wait_for_timeout(2000)` with polling via history API until the turn reaches `Completed` state (avoids CI flakiness) - Use `SEL["auth_screen"]` instead of hardcoded `"#auth-screen"` selector (follows project convention from helpers.py) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
nickpismenkov
approved these changes
Apr 14, 2026
henrypark133
added a commit
that referenced
this pull request
Apr 15, 2026
Merge staging into feat/rich-tool-history-cards, resolving the test_message_persistence.py conflict (PR's superset version wins over the basic staging version from #2475). Also fix a bug where the processingThreads spinner would persist if a background thread ended with "Interrupted", "Rejected", or "Tool call denied." — only "Done" and "Awaiting approval" were clearing the Set, leaving stale spinners until the next SSE reconnect. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Apr 15, 2026
This was referenced Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_message_persists_across_page_reloadE2E test that validates the full persistence round-trip: send a message, reload the page, verify both user message and assistant response survive from DBTest plan
pytest scenarios/test_message_persistence.py -vpasses locally (10.97s)🤖 Generated with Claude Code