style(agent): remove unnecessary Worker re-export (fix #891)#923
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving code hygiene by removing a redundant public re-export in the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes an unnecessary public re-export of Worker and WorkerDeps from the agent module. This is a good cleanup that reduces the module's public API surface. As confirmed in the pull request description, this change does not affect any internal consumers. The change is correct and improves maintainability. I have no further comments.
a48e481 to
78766e9
Compare
zmanian
left a comment
There was a problem hiding this comment.
LGTM. Trivial one-line removal of pub use crate::worker::{Worker, WorkerDeps} from agent/mod.rs.
Confirmed no callers import Worker or WorkerDeps through crate::agent:: -- all usages go through crate::worker:: directly. No downstream breakage.
Summary
Removes an unnecessary public re-export from
src/agent/mod.rsto satisfy issue #891 and align with the project style guideline (no facade re-exports unless needed by downstream consumers).pub use crate::worker::{Worker, WorkerDeps};Issue
Reproduction (before)
On
staging, the redundant re-export exists:And there are no in-repo consumers via the facade path:
Behavior (after)
The re-export is removed from
src/agent/mod.rs:No internal imports depended on the removed facade path.
Validation
Targeted tests:
Build sanity:
All passed locally.
Scope
Minimal, single-line deletion in one file; no behavioral/runtime logic changes.