Skip to content

Conversation

@ChristopherHX
Copy link
Contributor

  • do not require code changes at several places
  • self referencing anchors cause error

Closes #5947

* do not require code changes at several places
* self referencing anchors cause error
@mergify mergify bot added the needs-work Extra attention is needed label Dec 29, 2025
@github-actions
Copy link
Contributor

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 5 0 0.02s
✅ REPOSITORY gitleaks yes no 2.82s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 13.98s
✅ REPOSITORY secretlint yes no 1.38s
✅ REPOSITORY trivy-sbom yes no 0.61s
✅ REPOSITORY trufflehog yes no 3.78s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@ChristopherHX
Copy link
Contributor Author

Fixed here an additional bug in cycle detection of e.g.

a: &b x
b: &a
   ref: *b
c: *a

Now passes, previously this was accidentally detected as cycle.

@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.78%. Comparing base (bd4bc99) to head (d4d57d8).
⚠️ Report is 31 commits behind head on master.

Files with missing lines Patch % Lines
pkg/model/workflow.go 0.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5987      +/-   ##
==========================================
+ Coverage   74.65%   76.78%   +2.12%     
==========================================
  Files          73       74       +1     
  Lines       11139     9225    -1914     
==========================================
- Hits         8316     7083    -1233     
+ Misses       2186     1505     -681     
  Partials      637      637              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify mergify bot removed the needs-work Extra attention is needed label Dec 29, 2025
@mergify mergify bot added the queued label Dec 30, 2025
@mergify mergify bot merged commit b2aee4b into master Dec 30, 2025
11 of 12 checks passed
@mergify mergify bot deleted the christopherhx/explode-yaml-anchors branch December 30, 2025 21:50
@mergify
Copy link
Contributor

mergify bot commented Dec 30, 2025

Merge Queue Status

✅ The pull request has been merged at d4d57d8

This pull request spent 6 seconds in the queue, with no time running CI.
The checks were run in-place.

Required conditions to merge

@mergify mergify bot removed the queued label Dec 30, 2025
@ChristopherHX
Copy link
Contributor Author

Thank you for taking a look ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Explode / Expand YAML Anchors before parsing the workflow

3 participants