fix(ruby_lsp): set cmd_cwd to root_dir#4099
Merged
justinmk merged 1 commit intoneovim:masterfrom Sep 25, 2025
Merged
Conversation
c637b02 to
edbf5a4
Compare
Problem: When running from a directory other than root (i.e monorepo), ruby-lsp does not load correctly. Unsure why, previous lspconfig had cmd_cwd set to the same as root_dir. Solution: Set the cmd_cwd via reuse_client(), similar to ast_grep. See neovim#3850, neovim#4082 for more details. Tested both from root_dir and monorepo multi-root project.
edbf5a4 to
b553da4
Compare
Contributor
Author
|
Previous lspconfig: nvim-lspconfig/lua/lspconfig/manager.lua Lines 116 to 120 in 33d351c |
Member
Oh interesting. I wonder if |
Member
Yeah, maybe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
When running from a directory other than root (i.e monorepo), ruby-lsp does not load correctly. Unsure why, previous lspconfig had cmd_cwd set to the same as root_dir.
Solution:
Set the cmd_cwd via reuse_client(), similar to ast_grep. See #3850, #4082 for more details.
Tested both from root_dir and monorepo multi-root.