Check the SkyBox Dimming when looking on the Planet from it's dark side.

[Lisias]

Fellow Kerbonaut Krazy1 reported on Forum a possible enhancement for the SkyBox Dimming.

I think I see a new issue... The skybox dims when in low orbit at night (eclipsed) and looking at the planet (which is also in the direction of the sun). It's like you're looking at the sun without the planet blocking the sunlight. I don't think it did this before but maybe I'm wrong.

Check it and implement it if needed.

Use Cases

This task should not be considered closed again without a checkmark on every one of the following Use Cases.

• When the Camera is looking into the Sun, the Sky shall dim.
• When the Camera is looking into a Planet's illuminated side, the Sky shall dim.
• When the Camera is looking into a Planet's dark side, the Sky shall be visible.
• When the Camera is looking away from the Sun and from any planet, the Sky shall be visible.
• When the Camera is "landed" on an atmosphereless body, the Sky shall dim when the ground is being illuminated.
• When the Camera is "landed" on an atmosphereless body, the Sky shall dim when looking at the sun.

[Lisias]

Jesus Christ! I did it! And it was pretty easy, to tell you the true - I was kinda right initially, but I focused on the wrong GameObject and this was the reason things wasn't working...

Implemented on d26904f

[Lisias]

I inadvertently squashed the planet's influence on the skybox dimming.

Fixed on bbd669d and republished on 2.2.1.1

[Lisias]

The difference between humility and humiliation is... thin. 😃

I removed everything mentioned on this issue, replaced a min with a max and it solved the whole issue without collateral effects.

Oh, the joy of fixing issues by removing code... 😆

Fixed (again) on 266884b

[Lisias]

When something is too good to be true, usually it's because it is. Reopening this thing, my last commit solved a single use case and screwed the others.