[self-hosted] Remove extra proxy domain from getting started

[mlsmaycon]

Describe your changes

Issue ticket number and link

Stack

Checklist

• Is it a bug fix
• Is a typo/documentation fix
• Is a feature enhancement
• It is a refactor
• Created tests that fail without the change (if possible)

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

• I added/updated documentation for this change
• Documentation is not needed for this change (explain why)

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

netbirdio/docs#648

Summary by CodeRabbit

• Refactor
  • Streamlined the installation and setup process by automating proxy domain configuration.
  • Users no longer need to manually specify a proxy domain during setup; it is now automatically derived from the primary domain setting.
  • Updated configuration instructions and environment rendering to reflect simplified proxy domain handling.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR removes the interactive proxy domain input flow and simplifies proxy domain handling by consolidating all references to use NETBIRD_DOMAIN instead of the separate PROXY_DOMAIN variable. The read_proxy_domain function and related prompts are removed from the setup script.

Changes

Cohort / File(s)	Summary
Proxy Domain Consolidation infrastructure_files/getting-started.sh	Removed read_proxy_domain() function, eliminated PROXY_DOMAIN variable initialization, and replaced all PROXY_DOMAIN references with NETBIRD_DOMAIN throughout proxy configuration rendering and instruction text.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• Feat/quickstart reverse proxy assistant #5100: Modifies reverse-proxy flow and domain initialization logic in the same script.
• [misc] add extra proxy domain instructions #5328: Adjusts proxy-domain handling and related prompts in the getting-started script configuration.
• Fix reverse proxy getting started messaging #5317: Updates reverse-proxy setup flow and proxy-domain messaging in the same file.

Suggested reviewers

• braginini
• pascal-fischer

Poem

🐰 One domain to rule them all,
No more prompts when proxies call,
NETBIRD_DOMAIN stands alone,
Simpler setup, cleaner zone! 🌐

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	⚠️ Warning	The pull request description lacks a clear textual explanation of changes; only screenshots are provided without substantive detail about what was modified and why.	Add a detailed written explanation of the changes made (e.g., removal of proxy domain logic, migration to NETBIRD_DOMAIN), provide the issue ticket number/link, and fill in the actual Docs PR URL (currently a placeholder).

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: removing extra proxy domain logic from the getting started script, which aligns with the removal of PROXY_DOMAIN and read_proxy_domain function.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch remove-extra-proxy-domain-flow

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@infrastructure_files/getting-started.sh`:
- Line 774: The change makes NB_PROXY_DOMAIN equal NETBIRD_DOMAIN, which alters
the public proxy base and breaks existing docs/UI expectations; restore a
dedicated proxy base by reverting the assignment so NB_PROXY_DOMAIN remains a
separate configurable value (restore the previous default or use a dedicated
variable like PROXY_DOMAIN) instead of pointing it to NETBIRD_DOMAIN, or if you
intend this contract change, update the reverse-proxy/HA docs and any UI that
displays generated service URLs in the same release; locate and fix the
assignment of NB_PROXY_DOMAIN in getting-started.sh and ensure related config
generation and documentation/UI are updated consistently.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4f9d78d5-e7d6-4dd9-a9e2-57962861046a

📥 Commits

Reviewing files that changed from the base of the PR and between 11f8912 and ee70e6c.

📒 Files selected for processing (1)

• infrastructure_files/getting-started.sh