Make env/arg sanity check failure messages more useful #4676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 1373136 into 9a81078 - view on LGTM.com new alerts:
|
hlein
force-pushed
the
firejail_envchecks
branch
from
1373136 to
e4f1380
Compare
kmk3
reviewed
Nov 10, 2021
Collaborator
kmk3
left a comment
kmk3
left a comment
There was a problem hiding this comment.
Other than the suggestions, LGTM.
This change doesn't alter any checks, but it gives more specific errors when a sanity check of env vars or argv does not pass, which can point to limits to raise or at least give us better detailed bug reports. Signed-off-by: Hank Leininger <[email protected]> Bug: netblue30#3678 Bug: netblue30#3851 Bug: netblue30#4633
hlein
force-pushed
the
firejail_envchecks
branch
from
e4f1380 to
0d06369
Compare
Owner
|
merged, thanks! |
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Feb 21, 2023
Also, s/arguments/argument/ since the message refers to one specific argument. Relates to commit 0d06369 ("Make env/arg sanity check failure messages more useful", 2021-11-10) / PR netblue30#4676.
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Feb 21, 2023
Also, s/arguments/argument/ since the message refers to one specific argument. Relates to commit 0d06369 ("Make env/arg sanity check failure messages more useful", 2021-11-10) / PR netblue30#4676. Relates to netblue30#5676.
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Nov 1, 2025
Replace the hardcoded `MAX_ENVS` and `MAX_ENV_LEN` limits with new global configuration options, `env-max-count` and `env-max-len`, which limit the maximum number of environment variables and the maximum length of each environment variable (respectively). Also, include the environment name and value in the "too long environment variable" error message, similarly to the "too long argument" error message (see PR netblue30#4676 and PR netblue30#5677). This is a follow-up to netblue30#6878. Closes netblue30#3678.
kmk3
added a commit
that referenced
this pull request
Nov 1, 2025
Replace the hardcoded `MAX_ENVS` and `MAX_ENV_LEN` limits with new global configuration options, `env-max-count` and `env-max-len`, which limit the maximum number of environment variables and the maximum length of each environment variable (respectively). Also, include the environment name and value in the "too long environment variable" error message, similarly to the "too long argument" error message (see PR #4676 and PR #5677). This is a follow-up to #6878. Closes #3678.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change doesn't alter any checks, but it gives more specific
errors when a sanity check of env vars or argv does not pass, which
can point to limits to raise or at least give us better detailed bug
reports.
Signed-off-by: Hank Leininger [email protected]
Bug: #3678
Bug: #3851
Bug: #4633