fix: proxy support from environment for HTTP client#54
Merged
mfiedorowicz merged 1 commit intodevelopfrom Jan 7, 2026
Merged
Conversation
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
mfiedorowicz
requested review from
MicahParks,
jajeffries,
leoparente and
ltucker
as code owners
leoparente
approved these changes
Jan 7, 2026
MicahParks
approved these changes
Jan 7, 2026
|
Go test coverage
Total coverage: 76.5% |
mfiedorowicz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor update to the HTTP client transport configuration in
diode/client.go. The change ensures that the HTTP client honors proxy settings from the environment for both plaintext and TLS connections.http.Transportinitialization in theauthenticatemethod to set theProxyfield tohttp.ProxyFromEnvironment, allowing the client to use environment proxy settings for both HTTP and HTTPS connections.