fix(build): speed up NSIS overlay install by async old dir removal#1633
Merged
liuzhq1986 merged 1 commit intoApr 11, 2026
Conversation
Replace synchronous RMDir /r with rename-then-async-delete strategy. The old install directory (3000+ files in cfmind/SKILLs/node_modules) was deleted synchronously in customInit, blocking the installer UI. Now we rename $INSTDIR instantly and delete in background via cmd /c. If rename fails, skip and let the installer's built-in uninstall handle it.
9847800
into
netease-youdao:release/2026.04.13
25 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace synchronous RMDir /r with rename-then-async-delete strategy. The old install directory (3000+ files in cfmind/SKILLs/node_modules) was deleted synchronously in customInit, blocking the installer UI. Now we rename $INSTDIR instantly and delete in background via cmd /c. If rename fails, skip and let the installer's built-in uninstall handle it.
Summary
Related Issue
Fixes #(issue number)
Changes Made
Type of Change
Testing
Screenshots (if applicable)
Checklist
Electron-Specific Changes
Additional Notes