Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the analyzer dependency from version 8 to version 9, addressing issue #251 which requested analyzer 9.0.0 support for compatibility with json_serializable 6.11.3. The changes involve migrating from the deprecated analyzer element2 API to the current element API, along with SDK and dependency updates.
Key Changes:
- Migrated from analyzer's deprecated
element2API to the currentelementAPI throughout the codebase - Updated analyzer dependency from
>=8.1.1 <9.0.0to^9.0.0and SDK from^3.8.0to^3.9.0 - Refactored test fixtures to use
with EquatableMixininstead ofextends Equatableand added AAA (Arrange-Act-Assert) structure to tests
Reviewed changes
Copilot reviewed 96 out of 96 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pubspec.yaml files | Updated SDK to ^3.9.0, analyzer to ^9.0.0, melos to ^7.3.0, netglade_analysis to ^19.0.0 |
| lib/src/**/*.dart | Migrated from deprecated element2 API (element2, element3, name3, library2, etc.) to element API (element, name, library, etc.) |
| test fixtures | Changed from extends Equatable to with EquatableMixin pattern |
| test files | Added AAA comments, numeric separators, and formatting improvements |
| .fvmrc | Removed updateVscodeSettings configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
petrnymsa
previously approved these changes
Jan 6, 2026
petrnymsa
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #251