Fix JoniRegularExpression compatibility issues with ECMA-262#1193
Merged
stevehu merged 1 commit intonetworknt:masterfrom Sep 13, 2025
Merged
Fix JoniRegularExpression compatibility issues with ECMA-262#1193stevehu merged 1 commit intonetworknt:masterfrom
stevehu merged 1 commit intonetworknt:masterfrom
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1193 +/- ##
============================================
- Coverage 78.90% 78.10% -0.80%
- Complexity 1965 2082 +117
============================================
Files 172 201 +29
Lines 6352 6930 +578
Branches 1255 1267 +12
============================================
+ Hits 5012 5413 +401
- Misses 867 1041 +174
- Partials 473 476 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stevehu
approved these changes
Sep 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1192
This fixes the underlying discrepancies in the code ranges for the character classes
\d,\D,\w,\W,\s,\Sin ECMA-262 vs the mappings to the unicode general categories. As such this also fixes the case where these character classes are used in a character set.In the process of fixing this it was also noted that
\p{digit}is mapping to\dwhere it should be to\p{Nd}so this was fixed as well.