Refactor evaluation context out from validator state#1199
Merged
stevehu merged 1 commit intonetworknt:masterfrom Oct 12, 2025
Merged
Refactor evaluation context out from validator state#1199stevehu merged 1 commit intonetworknt:masterfrom
stevehu merged 1 commit intonetworknt:masterfrom
Conversation
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1199 +/- ##
============================================
- Coverage 78.90% 77.91% -1.00%
+ Complexity 1965 1900 -65
============================================
Files 172 199 +27
Lines 6352 6596 +244
Branches 1255 1164 -91
============================================
+ Hits 5012 5139 +127
- Misses 867 1025 +158
+ Partials 473 432 -41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Totally agree. We should focus on stability to make it enterprise-ready. Thanks a lot for the big effort. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the evaluation context from the validator state. This means that long evaluation chains no longer consume large amounts of memory as the same loaded schemas and validators can be used. The evaluation context is instead stored in the execution context.
This is unfortunately not without a cost. The performance benchmark of the schema and inputs previously used drop from 8000 ops/s to 4600 ops/s. This should still be above Everit's benchmark of around 4000 ops/s.
That said, this tradeoff is still acceptable as it makes the validator more robust in handling certain types of schemas.