Check for equivalence of term labels for duplicate TermURLs across nodes

[alyssadai]

federation-api/app/api/crud.py

Lines 163 to 165 in 9d685db

	for list_of_terms in cross_node_results:
	for term in list_of_terms[data_element_URI]:
	unique_terms_dict[term["TermURL"]] = term

If we overwrite previous instances here, would it be reasonable to check first if the term is the same as the one we've already stored? If we ever encounter a situation where some jokester has a neurobagel node where they just make up their own TermURLs for our terms, we could end up with a tricky to debug situation if all that determines what we return here is the order in which we unpack the responses from nodes.

Originally posted by @surchs in #65 (comment)

[surchs]

I would vote to bump this from the backlog and give it a someday label instead - this is a yet-to-be-encountered problem. We should address it, but we have more pressing things to do at the moment I think

[alyssadai]

Sure, that sounds okay to me.

[github-actions]

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 75 days.
We have applied the _flag:stale label to indicate that this issue should be reviewed again.
When you review, please reread the spec and then apply one of these three options:

• prioritize: apply the flag:schedule label to suggest moving this issue into the backlog now
• close: if the issue is no longer relevant, explain why (give others a chance to reply) and then close.
• archive: sometimes an issue has important information or ideas but we won't work on it soon. In this case
  apply the someday label to show that this won't be prioritized. The stalebot will ignore issues with this
  label in the future. Use sparingly!