Skip to content

[MNT] Switch to using Apptainer command in "How to get data" instructions#666

Merged
alyssadai merged 1 commit into
mainfrom
singularity-to-apptainer
Nov 12, 2025
Merged

[MNT] Switch to using Apptainer command in "How to get data" instructions#666
alyssadai merged 1 commit into
mainfrom
singularity-to-apptainer

Conversation

@alyssadai
Copy link
Copy Markdown
Contributor

@alyssadai alyssadai commented Nov 11, 2025

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass
  • If the PR changes the participant-level and/or the dataset-level result file, the query-tool-results files in the neurobagel_examples repo have been regenerated

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

Summary by Sourcery

Switch the “How to get data” instructions and tests to use Apptainer instead of Singularity

Enhancements:

  • Replace Singularity with Apptainer for the data retrieval run command in the GetDataDialog component

Tests:

  • Update component tests to assert on the apptainer toggle and run command instead of singularity

@alyssadai alyssadai added the pr-patch Incremental feature improvement, will increment patch version when merged (0.0.+1) label Nov 11, 2025
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Nov 11, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Switched the data retrieval instructions from Singularity to Apptainer by updating the component’s command mapping and aligning the corresponding UI and tests.

Class diagram for updated GetDataDialog command mapping

classDiagram
  class GetDataDialog {
    +open: boolean
    +onClose: () => void
    +RUN_COMMANDS: string
    +theme
    +commandType
    +render()
  }
  class CodeBlock {
    +code: string
  }
  GetDataDialog --> CodeBlock
Loading

File-Level Changes

Change Details Files
Replaced Singularity with Apptainer in the data retrieval commands
  • Renamed the RUN_COMMANDS key from 'singularity' to 'apptainer' and updated its command string
  • Modified ToggleButtonGroup to include 'apptainer' instead of 'singularity'
src/components/GetDataDialog.tsx
Updated tests to reflect the Apptainer switch
  • Changed the test title to reference apptainer
  • Replaced 'singularity' button existence and click assertions with 'apptainer'
  • Updated expected CLI output from 'singularity run' to 'apptainer run'
cypress/component/GetDataDialog.cy.tsx

Assessment against linked issues

Issue Objective Addressed Explanation
#661 Update the tab title in the 'How to get data' modal from 'singularity' to 'apptainer'.
#661 Update the command in the 'How to get data' modal to use 'apptainer' instead of 'singularity'.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 11, 2025

Deploy Preview for neurobagel-query ready!

Name Link
🔨 Latest commit 3113581
🔍 Latest deploy log https://app.netlify.com/projects/neurobagel-query/deploys/69138b2ccaa35e00085c9d2d
😎 Deploy Preview https://deploy-preview-666--neurobagel-query.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@rmanaem rmanaem self-requested a review November 12, 2025 17:09
Copy link
Copy Markdown
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@alyssadai alyssadai added the release Create a release when this PR is merged label Nov 12, 2025
@alyssadai alyssadai merged commit 776d65a into main Nov 12, 2025
17 checks passed
@alyssadai alyssadai deleted the singularity-to-apptainer branch November 12, 2025 17:56
@neurobagel-bot
Copy link
Copy Markdown
Contributor

🚀 PR was released in v0.13.2 🚀

@neurobagel-bot neurobagel-bot Bot added the released This issue/pull request has been released. label Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-patch Incremental feature improvement, will increment patch version when merged (0.0.+1) release Create a release when this PR is merged released This issue/pull request has been released.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch to apptainer commands for "How to get data" modal

2 participants