[ENH] Fix dataset title to span full width in result card.#738
Open
gmarav05 wants to merge 1 commit intoneurobagel:mainfrom
Open
[ENH] Fix dataset title to span full width in result card.#738gmarav05 wants to merge 1 commit intoneurobagel:mainfrom
gmarav05 wants to merge 1 commit intoneurobagel:mainfrom
Conversation
✅ Deploy Preview for neurobagel-query ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Reviewer's GuideRefactors the dataset result card layout so the dataset title occupies a full-width first row with ellipsis-based overflow, while secondary metadata stays below, and removes name rendering from DatasetInfoColumn to centralize it in ResultCard and adjust vertical spacing between cards. Class diagram for updated ResultCard and DatasetInfoColumn componentsclassDiagram
class ResultCard {
+string datasetUuid
+string datasetName
+string nodeName
+boolean recordsProtected
+boolean checked
+string[] authors
+string or null homepage
+string or null repositoryUrl
+string or null license
+string or null ethicsApproval
+string or null ethicsApprovalIdentifier
+string[] imagingModalities
+number subjectCount
+boolean hasPhenotypicData
+boolean hasImagingData
+boolean hasGeneticData
+function onCheckboxChange(id)
-boolean isExpanded
+render()
}
class DatasetInfoColumn {
+string datasetUuid
+boolean checked
+string[] authors
+string or null homepage
+string or null repositoryUrl
+string or null license
+string or null ethicsApproval
+string or null ethicsApprovalIdentifier
+string[] imagingModalities
+number subjectCount
+boolean hasPhenotypicData
+boolean hasImagingData
+boolean hasGeneticData
+function onCheckboxChange(id)
+render()
}
ResultCard --> DatasetInfoColumn : renders
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Signed-off-by: Aravind <gmarav005@gmail.com>
00709ca to
5f2a6b5
Compare
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Changed the dataset result card layout from a single-row to a two-row grid layout.
Row 1 Dataset name now spans the full width of the card 12 columns now.
Row 2 Authors, icons, subject count, and imaging modalities are below.
Removed the 39-character truncation on dataset names and names now uses CSS text-overflow when needed.
Updated
DatasetInfoColumnto no longer render the dataset name (moved toResultCard)Before
Dataset names were truncated after 39 characters and shared horizontal space with other card content.
After
Dataset names use the full card width, it makes long descriptive names easier to read.
Checklist
This section is for the PR reviewer
[ENH],[FIX],[REF],[TST],[CI],[MNT],[INF],[MODEL],[DOC]) (see our Contributing Guidelines for more info)skip-release(to be applied by maintainers only)Closes #XXXXquery-tool-resultsfiles in the neurobagel_examples repo have been regeneratedFor new features:
For bug fixes:
Summary by Sourcery
Update dataset result card layout to give the dataset title full-width prominence and adjust surrounding content accordingly.
New Features:
Enhancements: