-
Notifications
You must be signed in to change notification settings - Fork 9
Fix license deprecations and align setuptools requirements #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey @sfmig! Gentle ping, all checks are green. Thanks for taking a look when you get time. |
sfmig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AlgoFoe, thanks for addressing this update!
I left a few comments in-line but it should be almost good to go.
I also noticed we should additionally update the license syntax and the build system requirements in the pyproject.toml file of the cookiecutter project itself (this file). Would you mind adding that?
Thanks again!
for more information, see https://pre-commit.ci
|
thanks @AlgoFoe ! I think this is ready to go 🚀 |
Description
What is this PR
Why is this PR needed?
movement, the same changes are needed here to keep the packaging setup consistent and future-proof.What does this PR do?
pre-committooling.References
How has this PR been tested?
Is this a breaking change?
Does this PR require an update to the documentation?
Checklist: