Skip to content

Modernize package and add Vue dialog#378

Merged
ChristophWurst merged 1 commit intomasterfrom
feat/dialog
Sep 7, 2022
Merged

Modernize package and add Vue dialog#378
ChristophWurst merged 1 commit intomasterfrom
feat/dialog

Conversation

@Pytal
Copy link
Contributor

@Pytal Pytal commented Aug 27, 2022

Close nextcloud/server#33675

Breaking

  • Default export has been dropped, the function must now be imported with import { confirmPassword } from '@nextcloud/password-confirmation'
  • Dialog styles must be imported with import '@nextcloud/password-confirmation/style.css'

Changed

  • Core password confirmation logic and dialog markup has been ported to this package where previously this package was a thin wrapper over the OC.PasswordConfirmation global js namespace
  • Use https://github.com/vitejs/vite as the build system
  • Drop Babel toolchain
  • Add translation files
  • Add GitHub workflows
  • Dependency updates

@Pytal Pytal added enhancement New feature or request 2. developing Work in progress labels Aug 27, 2022
@Pytal Pytal added this to the 3.0.0 milestone Aug 27, 2022
@Pytal Pytal self-assigned this Aug 27, 2022
@Pytal Pytal force-pushed the feat/dialog branch 2 times, most recently from 784ecae to 20d7880 Compare September 1, 2022 06:26
@Pytal Pytal force-pushed the feat/dialog branch 5 times, most recently from c4d965b to 13866ac Compare September 3, 2022 04:51
@Pytal

This comment was marked as resolved.

@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 3, 2022
@Pytal Pytal requested a review from CarlSchwan September 3, 2022 04:57
@Pytal Pytal marked this pull request as ready for review September 3, 2022 04:57
@Pytal Pytal requested a review from artonge September 3, 2022 05:12
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@ChristophWurst ChristophWurst merged commit 003a19e into master Sep 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the feat/dialog branch September 7, 2022 07:57
@ChristophWurst
Copy link
Contributor

Do you want me to release this right away?

@Pytal
Copy link
Contributor Author

Pytal commented Sep 7, 2022

Do you want me to release this right away?

Let's do it! #383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews accessibility enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port password confirmation dialog to vue

3 participants