Update R8/ProGuard section of README.md#635
Conversation
Unpublished
left a comment
There was a problem hiding this comment.
I don't have a strong opinion on this.
I think some breakages in downstream apps caused by obfuscation could be fixed in this library. But would require a lot effort/time to narrow down.
Thats why I personally wouldn't advertise using "will automatically work without additional app level rules".
This is partially covered with line 286, though.
|
Are there known breakages in downstream apps? For the two apps I worked with it was fine. |
|
The news app had crashes related to sso with obfuscation enabled last time I tested. In case you try to reproduce: |
|
I built the news-android app without |
|
I'd call |
|
Oh that are the application classes, I was looking for |
Unpublished
left a comment
There was a problem hiding this comment.
Since there are no known broken downstream apps anymore this can be merged
Signed-off-by: Konrad Pozniak <connyduck@users.noreply.github.com>
fabc529 to
b03258b
Compare
closes #572