Create headings for sidebar pages#1081
Merged
JuliaKirschenheuter merged 1 commit intomasterfrom Mar 8, 2023
Merged
Conversation
JuliaKirschenheuter
requested review from
Pytal,
artonge,
nickvergessen and
szaimen
JuliaKirschenheuter
force-pushed
the
fix/35626-No_heading_nor_tab_index_for_settings_pages
branch
from
231e6b2 to
0e1df7d
Compare
nickvergessen
previously requested changes
Feb 10, 2023
Member
|
Where is the section defined. I assume a generic PR in server? How is ensured that it is not added when there is an h1 already. |
Contributor
Author
|
/backport to stable25 |
9 tasks
JuliaKirschenheuter
force-pushed
the
fix/35626-No_heading_nor_tab_index_for_settings_pages
branch
2 times, most recently
from
65ca0af to
3b9e51a
Compare
Contributor
Author
|
/backport to stable26 |
Pytal
approved these changes
Mar 3, 2023
artonge
approved these changes
Mar 6, 2023
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
JuliaKirschenheuter
force-pushed
the
fix/35626-No_heading_nor_tab_index_for_settings_pages
branch
from
6f96282 to
eab9671
Compare
delete-merged-branch
bot
deleted the
fix/35626-No_heading_nor_tab_index_for_settings_pages
branch
This was referenced Mar 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to nextcloud/server#35626, fixes "Activity" part
After: