Skip to content

Comments

add a workflow that blocks merging if a pre-release was published#7522

Merged
szaimen merged 2 commits intomainfrom
enh/noid/block-merging
Jan 30, 2026
Merged

add a workflow that blocks merging if a pre-release was published#7522
szaimen merged 2 commits intomainfrom
enh/noid/block-merging

Conversation

@szaimen
Copy link
Collaborator

@szaimen szaimen commented Jan 30, 2026

No description provided.

@szaimen szaimen added 2. developing Work in progress enhancement New feature or request labels Jan 30, 2026
@szaimen szaimen force-pushed the enh/noid/block-merging branch 2 times, most recently from 66a469e to bdd7427 Compare January 30, 2026 10:37
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 30, 2026
@szaimen szaimen added this to the next milestone Jan 30, 2026
@szaimen szaimen requested a review from pabzm January 30, 2026 10:39
@szaimen szaimen marked this pull request as ready for review January 30, 2026 10:41
@szaimen
Copy link
Collaborator Author

szaimen commented Jan 30, 2026

The workflow is ready (it is designed to fail currently, so working as intended ☺️)

Copy link
Member

@pabzm pabzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this looks good to me, thanks! I have only minor nitpicks, which you could push aside, if you prefer.

Signed-off-by: Simon L. <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/noid/block-merging branch from bdd7427 to b1cea36 Compare January 30, 2026 13:41
@szaimen szaimen requested a review from pabzm January 30, 2026 13:49
Signed-off-by: Simon L. <szaimen@e.mail.de>
Copy link
Member

@pabzm pabzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@szaimen
Copy link
Collaborator Author

szaimen commented Jan 30, 2026

Thanks for the review Pablo! ☺️

@szaimen szaimen merged commit 4ecb870 into main Jan 30, 2026
3 of 4 checks passed
@szaimen szaimen deleted the enh/noid/block-merging branch January 30, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants