Minor fixes for auto-approve workflows#44
Merged
tobiasKaminsky merged 3 commits intomainfrom Feb 9, 2023
Merged
Conversation
As explained in nextcloud/android-library#1060 (comment), the sync action adds the label *after* opening the PR, so when this workflow runs the label isn't there yet, and the auto-approve action will be skipped. This fixes that by also running this workflow when the PR is labeled. Also added a concurrency group to avoid running this in parallel. Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
tobiasKaminsky
previously approved these changes
Feb 9, 2023
…em more easily Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
better than skipping step Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
AlvaroBrey
changed the title
Member
Author
|
Added another couple of minor improvements, check commit messages |
tobiasKaminsky
approved these changes
Feb 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As explained in nextcloud/android-library#1060 (comment), the sync
action adds the label after opening the PR, so when this workflow runs the label isn't there yet,
and the auto-approve action will be skipped.
This fixes that by also running this workflow when the PR is labeled.
opened,reopenedandsynchronizeare the default triggers, I just addedlabeledAlso added a concurrency group to avoid running this in parallel.