Skip to content

Comments

Prevent URI uploads from external apps that target private storage#10544

Merged
AlvaroBrey merged 5 commits intomasterfrom
fix/upload-external-uri-internal-path
Aug 5, 2022
Merged

Prevent URI uploads from external apps that target private storage#10544
AlvaroBrey merged 5 commits intomasterfrom
fix/upload-external-uri-internal-path

Conversation

@AlvaroBrey
Copy link
Member

@AlvaroBrey AlvaroBrey commented Jul 20, 2022

Successor to #9645

  • Tests written, or not not needed

AlvaroBrey and others added 5 commits August 4, 2022 15:56
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
…pp's package name

Prevent leaks of files in this app's storage

Co-authored-by: Tobias Kaminsky <tobias@kaminsky.me>
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
It's now a NestedScrollView

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
@AlvaroBrey AlvaroBrey force-pushed the fix/upload-external-uri-internal-path branch from 695ea0f to 64ddaf4 Compare August 4, 2022 13:57
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10544.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

github-actions bot commented Aug 4, 2022

Codacy

Lint

TypemasterPR
Warnings8585
Errors00

SpotBugs

CategoryBaseNew
Bad practice2929
Correctness4646
Dodgy code353353
Experimental11
Internationalization99
Multithreaded correctness99
Performance5959
Security2828
Total534534

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #10544 (64ddaf4) into master (f0bde3d) will decrease coverage by 0.03%.
The diff coverage is 26.02%.

@@             Coverage Diff              @@
##             master   #10544      +/-   ##
============================================
- Coverage     31.54%   31.50%   -0.04%     
+ Complexity     3287     3280       -7     
============================================
  Files           540      540              
  Lines         40209    40218       +9     
  Branches       5557     5557              
============================================
- Hits          12683    12670      -13     
- Misses        25616    25664      +48     
+ Partials       1910     1884      -26     
Impacted Files Coverage Δ
.../owncloud/android/files/services/FileUploader.java 50.91% <ø> (-3.12%) ⬇️
...roid/ui/activity/ReceiveExternalFilesActivity.java 0.35% <ø> (ø)
...ava/com/owncloud/android/ui/helpers/UriUploader.kt 26.02% <26.02%> (ø)
...main/java/com/owncloud/android/utils/FileUtil.java 60.00% <0.00%> (-26.67%) ⬇️
...om/owncloud/android/utils/ErrorMessageAdapter.java 3.36% <0.00%> (-3.85%) ⬇️
.../owncloud/android/ui/adapter/OCFileListDelegate.kt 49.63% <0.00%> (-1.46%) ⬇️
...a/com/owncloud/android/utils/FileStorageUtils.java 54.77% <0.00%> (-1.11%) ⬇️
...loud/android/datamodel/ThumbnailsCacheManager.java 38.70% <0.00%> (-0.72%) ⬇️
...xtcloud/client/account/UserAccountManagerImpl.java 71.62% <0.00%> (-0.68%) ⬇️
... and 7 more

@AlvaroBrey
Copy link
Member Author

/backport to stable-3.21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant