PassCodeManager: add some logic to avoid counting the same activity twice#11242
Merged
tobiasKaminsky merged 2 commits intomasterfrom Jan 12, 2023
Merged
PassCodeManager: add some logic to avoid counting the same activity twice#11242tobiasKaminsky merged 2 commits intomasterfrom
tobiasKaminsky merged 2 commits intomasterfrom
Conversation
…wice This is very specific to the case where an activity extending from AuthenticatorActivity _and_ running as `singleTask` gets restarted, in which case it calls `PassCodeManager.onActivityResumed` twice (once on `onResume` and once on `onNewIntent`). Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Member
Author
|
Looks like mocks arent working on android < P :( |
tobiasKaminsky
approved these changes
Jan 11, 2023
Can't mock PowerManager on Android < 9 Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11242.apk |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #11242 +/- ##
=============================================
+ Coverage 3.21% 31.25% +28.04%
- Complexity 426 3359 +2933
=============================================
Files 565 565
Lines 41568 41577 +9
Branches 5627 5629 +2
=============================================
+ Hits 1337 12996 +11659
+ Misses 40149 26637 -13512
- Partials 82 1944 +1862
|
1 task
surinder-tsys
added a commit
to nextmcloud/android
that referenced
this pull request
Jan 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is very specific to the case where an activity extending from AuthenticatorActivity and running as
singleTaskgets restarted, in which case it calls
PassCodeManager.onActivityResumedtwice (once ononResumeand once ononNewIntent).